-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): improve comment parsing code #1120
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
- Coverage 94% 93.98% -0.02%
==========================================
Files 120 120
Lines 5234 5185 -49
Branches 1450 1438 -12
==========================================
- Hits 4920 4873 -47
Misses 178 178
+ Partials 136 134 -2
|
Fixes #1114
Potentially could (fix) #1042 as well.
I figured that this was a solved problem, and it turns out it was.
tsutils had a function to do it.
It invovles adding a dep, but I figured it was better? I considered copying it but there are several hundred lines of code to copy, and we'd have ensure we honour the licence etc.